Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dirname apply to hidden/tel/url/email inputs. #28146

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

vinhill
Copy link
Contributor

@vinhill vinhill commented Jul 24, 2023

See whatwg/html#9490

Dirname should soon apply to input elements of type hidden/tel/url/email in addition to text and search.

@vinhill vinhill requested a review from a team as a code owner July 24, 2023 08:30
@vinhill vinhill requested review from chrisdavidmills and removed request for a team July 24, 2023 08:30
@github-actions github-actions bot added the Content:HTML Hypertext Markup Language docs label Jul 24, 2023
@bsmth bsmth added the waiting for implementations Waiting for feature to be implemented in browsers label Jul 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Preview URLs

(comment last updated: 2023-08-10 10:02:41)

@bsmth
Copy link
Member

bsmth commented Jul 24, 2023

Thanks a lot for the suggestions @vinhill - Is it correct that we're still waiting for implementations? We need at least one browser to support this before we merge. I've added the appropriate label for now.

@vinhill
Copy link
Contributor Author

vinhill commented Jul 24, 2023

@bsmth you're right. The spec just merged and I can add a note here once the change landed in Firefox.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinhill looks good, thanks! I've made a nitpicky suggestion on the attribute description, first to add a serial comma as per MDN style, and second to make some small changes to make the last sentence just a little bit easier to parse.

I've approved this, and we can get it merged when the change actually drops in Firefox.

files/en-us/web/html/element/input/index.md Outdated Show resolved Hide resolved
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@vinhill
Copy link
Contributor Author

vinhill commented Jul 25, 2023

The change landed, see mozilla/gecko-dev@6bb941a. @chrisdavidmills

@vinhill
Copy link
Contributor Author

vinhill commented Jul 25, 2023

Sorry, I thought it was already in Nightly, but that is not the case yet.

@vinhill
Copy link
Contributor Author

vinhill commented Aug 8, 2023

By now the change is applied to Nightly.

@bsmth
Copy link
Member

bsmth commented Aug 8, 2023

vinhill and others added 2 commits August 9, 2023 21:07
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Aug 9, 2023
@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Aug 10, 2023
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsmth bsmth merged commit 579534a into mdn:main Aug 10, 2023
6 checks passed
@bsmth bsmth removed the waiting for implementations Waiting for feature to be implemented in browsers label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants